feat(cloud_sql): Add Cloud SQL Server PITR #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PITR Terraform code samples for Cloud SQL for SQL Server.
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
glasnt
reviewed
Feb 11, 2025
glasnt
reviewed
Feb 11, 2025
glasnt
reviewed
Feb 11, 2025
glasnt
reviewed
Feb 11, 2025
Contributor
|
/gcbrun |
glasnt
reviewed
Feb 11, 2025
glasnt
reviewed
Feb 11, 2025
Contributor
|
/gcbrun |
Update edition for the Enterprise sample.
Updated editions for samples.
glasnt
reviewed
Feb 11, 2025
Contributor
|
/gcbrun |
rebecca-pete
commented
Feb 11, 2025
| region = "asia-northeast1" | ||
| database_version = "SQLSERVER_2019_ENTERPRISE" | ||
| settings { | ||
| tier = "db-custom-4-26624" |
Contributor
Author
There was a problem hiding this comment.
This sample should be for Enterprise, not Enterprise Plus. With this in mind, I think we want to reverse the change on line 45.
glasnt
reviewed
Feb 11, 2025
Contributor
|
/gcbrun |
glasnt
reviewed
Feb 11, 2025
glasnt
reviewed
Feb 11, 2025
Contributor
|
/gcbrun |
glasnt
approved these changes
Feb 11, 2025
niharika-98
pushed a commit
to niharika-98/terraform-docs-samples
that referenced
this pull request
Sep 7, 2025
) * Create main.tf Add PITR Terraform code samples for Cloud SQL for SQL Server. * terraform fmt * correct region tags * ensure unique resource names * Update main.tf Update edition for the Enterprise sample. * Update main.tf Updated editions for samples. * Update tier for enterprise plus * revert tier change * Add `root_password` argument --------- Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PITR Terraform code samples for Cloud SQL for SQL Server.
Description
Fixes #b/388607470
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review